acassis commented on code in PR #3110:
URL: https://github.com/apache/nuttx-apps/pull/3110#discussion_r2167208893
##########
system/settings/settings.c:
##########
@@ -1114,26 +1098,18 @@ int settings_create(FAR char *key, enum settings_type_e
type, ...)
FAR setting_t *setting = NULL;
int j;
- if (!g_settings.initialized)
- {
- assert(0);
- }
-
- assert(type != SETTING_EMPTY);
+ assert(g_settings.initialized);
- assert(strlen(key));
- if (strlen(key) == 0)
+ if (type == SETTING_EMPTY)
{
return -EINVAL;
}
- assert(strlen(key) < CONFIG_SYSTEM_SETTINGS_KEY_SIZE);
- if (strlen(key) >= CONFIG_SYSTEM_SETTINGS_KEY_SIZE)
+ if (strlen(key) == 0 || strlen(key) >= CONFIG_SYSTEM_SETTINGS_KEY_SIZE)
Review Comment:
@jeanthom so KEY_SIZE mean max size in this case, right? Maybe we can rename
it to CONFIG_SYSTEM_SET_MAX_KEY_SIZE. @TimJTi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
