jeanthom commented on code in PR #3110: URL: https://github.com/apache/nuttx-apps/pull/3110#discussion_r2166967335
########## system/settings/settings.c: ########## @@ -249,7 +249,6 @@ static int set_string(FAR setting_t *setting, FAR char *str) return -EACCES; } - ASSERT(strlen(str) < CONFIG_SYSTEM_SETTINGS_VALUE_SIZE); if (strlen(str) >= CONFIG_SYSTEM_SETTINGS_VALUE_SIZE) Review Comment: Similarly to my comment about key lengths: values can have mixed lengths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org