TimJTi commented on PR #3110: URL: https://github.com/apache/nuttx-apps/pull/3110#issuecomment-3005541792
> @TimJTi since you are the original author, please take a look too! Actually - I didn't write it but did "port" it to NuttX and am using it regularly. Once it is reviewed by others and "ready to merge" give me the heads up and all merge the PR and make sure it works OK for me still. Or are we there now? The original author was very keen I messed with as little as possible when I was making it "suitable for NuttX", and got me to "undo" things I'd changed (perhaps including better use of select/case rather than if/elseif/else etc!!! Can't please everybodt all the time LOL. As far as assert vs error code: having both means that if NDEBUG is set, disabling asserts, there are still error messages, but the program doesn't "crash" as such. I have seen this used in quite a few places and it seemed a good idea at the time, and is "benign"; but if its frowned upon here, so be it - although nobody complained during the reviews when I submitted the PR!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
