xiaoxiang781216 commented on a change in pull request #358:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/358#discussion_r468322659
##########
File path: graphics/lvgl/Makefile
##########
@@ -74,13 +74,9 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
@echo "Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
$(Q) $(UNPACK) $(LVGL_TARBALL)
$(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
- $(Q) touch $(LVGL_UNPACKNAME)
Review comment:
I tries two package(lvgl and libcanard), both don't hit the double
downloading issue. @Ouss4 could you help me confirm?
##########
File path: graphics/lvgl/Makefile
##########
@@ -74,13 +74,9 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
@echo "Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
$(Q) $(UNPACK) $(LVGL_TARBALL)
$(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
- $(Q) touch $(LVGL_UNPACKNAME)
Review comment:
I tries two package(lvgl and libcanard), both don't hit the double
downloading issue. @Ouss4 could you help me confirm it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
