Ouss4 commented on a change in pull request #358:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/358#discussion_r468399842
##########
File path: graphics/lvgl/Makefile
##########
@@ -74,13 +74,9 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
@echo "Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
$(Q) $(UNPACK) $(LVGL_TARBALL)
$(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
- $(Q) touch $(LVGL_UNPACKNAME)
Review comment:
libcanard's Makefile deletes the folder before unpacking, so we can't
see the issue there.
I just tried with lvgl, and I do get a second folder.
Is that an `mv` implementation difference? I'm running on Manjaro with
Coretutils 8.32, what's your platform?
Could you please try to manually inspect the timestamps with ls -l?
> both don't hit the double downloading issue
It doesn't download the archive again, it just unpacks the existing tar or
zip file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
