xiaoxiang781216 commented on a change in pull request #358:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/358#discussion_r468484798



##########
File path: graphics/lvgl/Makefile
##########
@@ -74,13 +74,9 @@ $(LVGL_UNPACKNAME): $(LVGL_TARBALL)
        @echo "Unpacking: $(LVGL_TARBALL) -> $(LVGL_UNPACKNAME)"
        $(Q) $(UNPACK) $(LVGL_TARBALL)
        $(Q) mv lvgl-$(LVGL_VERSION) $(LVGL_UNPACKNAME)
-       $(Q) touch $(LVGL_UNPACKNAME)

Review comment:
       Here is my test:
   ```
   drwxr-xr-x 9 xiaoxiang xiaoxiang    4096 2020-08-11 17:35:48.659398700 +0800 
lvgl
   -rw-r--r-- 1 xiaoxiang xiaoxiang 6847211 2020-08-11 17:35:14.369398700 +0800 
v7.0.2.zip
   ```
   and mv --version:
   ```
   xiaoxiang@DESKTOP-JH2VEP6:~/nuttx/nuttx$ mv --version
   mv (GNU coreutils) 8.28
   Copyright (C) 2017 Free Software Foundation, Inc.
   License GPLv3+: GNU GPL version 3 or later 
<http://gnu.org/licenses/gpl.html>.
   This is free software: you are free to change and redistribute it.
   There is NO WARRANTY, to the extent permitted by law.
   
   Written by Mike Parker, David MacKenzie, and Jim Meyering.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to