acassis commented on code in PR #16838:
URL: https://github.com/apache/nuttx/pull/16838#discussion_r2285142535


##########
boards/arm/rp2040/common/src/rp2040_common_bringup.c:
##########
@@ -569,6 +574,16 @@ int rp2040_common_bringup(void)
     }
 #endif
 
+#ifdef CONFIG_SENSORS_TMP112
+  /* Try to register TMP112 device at I2C0 with a common address */
+
+  ret = board_tmp112_initialize(rp2040_i2cbus_initialize(0), 0, 0x48);

Review Comment:
   Ok, after we merge it will submit the fix for all drivers, including this 
here. Something we noticed on NuttX is that bad practices spread more than good 
practices, this is why it is important to have only good examples in the source 
three. :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to