xiaoxiang781216 commented on code in PR #16838:
URL: https://github.com/apache/nuttx/pull/16838#discussion_r2285171918
##########
drivers/sensors/tmp112.c:
##########
@@ -282,40 +282,7 @@ int tmp112_register(FAR const char *devpath, uint8_t
devnum,
}
priv->i2c = i2c;
- switch (devnum)
Review Comment:
why add in the first patch and remove here, let's modify the first patch
instead
##########
drivers/sensors/Kconfig:
##########
@@ -2159,51 +2159,6 @@ config TMP112_I2C_FREQUENCY
int "TMP112 I2C frequency"
default 400000
-config TMP112_I2C_ADDR_1
Review Comment:
why add in the first patch and remove here, let's modify the first patch
instead
##########
include/nuttx/sensors/tmp112.h:
##########
@@ -36,8 +36,35 @@
* Pre-processor Definitions
****************************************************************************/
-#define TMP112_REG_CONFIG 0x01
-#define TMP112_REG_TEMP 0x00
+#define TMP112_REG_CONFIG 0x01
+#define TMP112_REG_TEMP 0x00
Review Comment:
move to the first patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
