xiaoxiang781216 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2347082907
########## boards/sim/sim/sim/configs/vncserver/defconfig: ########## @@ -12,6 +12,7 @@ CONFIG_ARCH_BOARD_SIM=y CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARD_LATE_INITIALIZE=y +CONFIG_BOARD_LOOPSPERMSEC=0 Review Comment: why add sim with the default 0? sim use other method for busy loop wait: https://github.com/apache/nuttx/blob/master/drivers/timers/arch_alarm.c#L410C20-L410C29 all boards which enable ARCH_ALARM/ARCH_TIMER don't need set CONFIG_BOARD_LOOPSPERMSEC at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
