xiaoxiang781216 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2347083064
########## boards/arm64/qemu/qemu-armv8a/configs/fastboot/defconfig: ########## @@ -16,6 +16,7 @@ CONFIG_ARCH_CHIP_QEMU=y CONFIG_ARCH_CHIP_QEMU_A53=y CONFIG_ARCH_INTERRUPTSTACK=4096 CONFIG_AUDIO=y +CONFIG_BOARD_LOOPSPERMSEC=354375 Review Comment: qemu use up_delay provided by: https://github.com/apache/nuttx/blob/master/drivers/timers/arch_alarm.c#L410C20-L410C29 don't need set CONFIG_BOARD_LOOPSPERMSEC. ########## include/nuttx/arch.h: ########## @@ -99,6 +99,18 @@ #define DEBUGPOINT_BREAKPOINT 0x04 #define DEBUGPOINT_STEPPOINT 0x05 +/* Ensure that LOOPSPERMSEC is not the default, invalid value. If it is, let + * the user know that they need to change it and then calibrate it. + */ + +static_assert( + CONFIG_BOARD_LOOPSPERMSEC >= 0, Review Comment: it's better to move the assert the place with really use it, since not all busy wait implementation depend on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
