linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2389538588
########## boards/sim/sim/sim/configs/vncserver/defconfig: ########## @@ -12,6 +12,7 @@ CONFIG_ARCH_BOARD_SIM=y CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARD_LATE_INITIALIZE=y +CONFIG_BOARD_LOOPSPERMSEC=0 Review Comment: @xiaoxiang781216 it looks like all of the failing builds for sim are the configurations without `BOARD_LOOPSPERMSEC=0`. These configurations also don't have `TIMER_ARCH` or `ARCH_ALARM` (at least the ones I saw). What I understand from this is that either sim is pulling its definition of `up_udelay` from elsewhere (I don't think this is the case, none of the other definitions that exist for it would be involved in a sim build) _or_ the behaviour of `up_udelay` doesn't matter for any of these sim configurations. Is it suitable to continue with adding `CONFIG_BOARD_LOOPSPERMSEC=0` to the remaining simulator configurations (they're all either using 0 or were using the old default value, so likely it doesn't affect anything)? Or is there some other approach you'd like me to take? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
