hartmannathan commented on PR #17300:
URL: https://github.com/apache/nuttx/pull/17300#issuecomment-3517253394

   > If everyone agrees that rtcb can never be NULL, then adding an assertion 
for rtcb in DEBUGASSERT would be redundant and unnecessary
   
   Hmm, everyone can agree that rtcb can never be NULL, but what if we missed 
something? Or, what if future changes in the codebase miss something? It's 
probably a good idea to check with DEBUGASSERT, to give us a chance to catch 
programmer mistakes in the future, and as a way of explicitly documenting the 
function's contract.
   
   I don't have a strong opinion about it. Either way is fine with me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to