xiaoxiang781216 commented on PR #17300: URL: https://github.com/apache/nuttx/pull/17300#issuecomment-3516478104
> > > @xiaoxiang781216 Why are you forcibly merging and committing when the change request is not resolved? cc @acassis @jerpelea @linguini1 > > > > > > the reason already express clearly, also assert NULL pointer is spread in the whole code base, I don't think there are any more to discuss. > > I think you should carefully review the code @hujun260 submitted. if DEBUGASSERT disabled, you guys removed the check if tcb is a null pointer. Why does enabling and disabling DEBUGASSERT mode will change the software behavior? The current tcb should never be NULL, that's why change the runtime check to DEBUGASSERT, which mean that it's a program error calling sched_lock with the current tcb is NULL, and should fix the cause which change the current tcb to NULL instead. Please read the online documentation to learn the difference between assert and runtime check: https://en.wikipedia.org/wiki/Assertion_(software_development) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
