anchao commented on code in PR #17300:
URL: https://github.com/apache/nuttx/pull/17300#discussion_r2513526376
##########
sched/sched/sched_lock.c:
##########
@@ -76,13 +76,13 @@ void sched_lock(void)
* integer type.
*/
- DEBUGASSERT(rtcb == NULL || rtcb->lockcount < MAX_LOCK_COUNT);
+ DEBUGASSERT(rtcb && rtcb->lockcount < MAX_LOCK_COUNT);
Review Comment:
For commercial projects, they have robust NULL pointer checks using MPU or
MMU, rather than letting the 99% of code running the Nuttx kernel bear the
brunt of these invalid comparison cycles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
