wangchdo commented on code in PR #17308:
URL: https://github.com/apache/nuttx/pull/17308#discussion_r2518769876
##########
sched/wdog/wd_start.c:
##########
@@ -313,6 +313,32 @@ int wd_start_abstick(FAR struct wdog_s *wdog, clock_t
ticks,
reassess |= wd_insert(wdog, ticks, wdentry, arg);
+ /* If the new watchdog expiration time is earlier than the current system
+ * time, trigger a timer interrupt manually. This ensures that the system
+ * processes the watchdog immediately instead of waiting for the next tick.
+ */
+
+ if (clock_compare(wdog->expired, clock_systime_ticks()))
+ {
+# ifdef CONFIG_ARCH_HAVE_IRQTRIGGER
+ if (up_timer_trigger() != OK)
Review Comment:
> The timer driver is responsible to generate the timer interrupt as soon as
possible in this case, why do we need add new api? the timer driver could
trigger the interrupt in up_timer_start/up_alarm_start directly.
>
>
Yes I now agree with you, I think it would be better to improve the current
timer driver instead of introducing new api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
