wangchdo commented on PR #17308:
URL: https://github.com/apache/nuttx/pull/17308#issuecomment-3530631108
> I have two main concerns:
>
> 1. You expect the expired timer to be triggered immediately, but your
timer is delayed by one tick. What's the difference between this and the
original implementation?
Fix the bug that nxsched_reassess_timer() be called with a timeout earlier
than the current time, this is dangerous, it will be stop the timer for a long
time
> 2. Each `wd_start` requires an extra `clock_systime_ticks()`, resulting in
an extra `~50` CPU cycles overhead. Can you provide test data to prove that
your patch will not cause a performance degradation?
This only exists for tickless implementation and it is needed, because it
is a bugfix
>
> To address this issue, I'm working on a better solution. Once the
count-based oneshot API (clockdevice) is merged, I will submit the new pull
request to fix this.
If so, it will be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
