wangchdo commented on PR #17675: URL: https://github.com/apache/nuttx/pull/17675#issuecomment-3691332629
@Fix-Point @xiaoxiang781216 @GUIDINGLI I really don’t want to get into a dispute again. If you decide to revert my implementation, I would prefer not to spend time arguing, as both implementations achieve the same new functionality and benefits for NuttX. **However, I would appreciate it if my implementation is not described as completely unusable, having functional issues, or being inferior in performance, readability, or effectiveness** **I believe my implementation is robust in all aspects and provides a solid foundation for future improvements. It also achieves better isolation from the current scheduler, making future enhancements safer and easier.** I acknowledge that the first version did not fully account for SMP, but I have submitted a fix ([#17642](https://github.com/apache/nuttx/pull/17642) ) that addresses all SMP cases. This fix is straightforward, as it focuses solely on improving the Hrtimer state-machine. Finally, before reverting my implementation, I would suggest performing a performance comparison with my PR ([#17573](https://github.com/apache/nuttx/pull/17573) ) to ensure the best outcome for NuttX. Regards Wang Chengdong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
