wangchdo commented on PR #17675: URL: https://github.com/apache/nuttx/pull/17675#issuecomment-3691477587
> > Setting aside the implementation details, there are far too many critical section issues that I haven’t pointed out them exhaustively. You are advised to fully resolve them before submitting the code. Also, please watch your wording. What is "**incorrect**"? I’m genuinely curious about your professionalism and respectfulness — you are essentially belittling the work of individual developers. > > > > I am sorry for my mistake. The `incorrect` should be `functional incorrect`, which means it is inconsistent with the design specifications. (E.g, a cancelled and restarted periodic timer will not never be overwritten by an old periodic timer callback that has not yet completed in any cases.) > > A minor fix can resolve the issue you mentioned #17642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
