anchao commented on code in PR #18016:
URL: https://github.com/apache/nuttx/pull/18016#discussion_r2710970949
##########
sched/task/task_cancelpt.c:
##########
@@ -125,14 +125,13 @@ bool nxnotify_cancellation(FAR struct tcb_s *tcb)
*/
tls->tl_cpstate |= CANCEL_FLAG_CANCEL_PENDING;
- leave_critical_section(flags);
- return true;
+ ret = true;
Review Comment:
Formal verification is completely unsuitable for software development
workflows. These constraints were only documented because early compilers were
riddled with bugs. I wonder if you have encountered a lot of odd issues while
using the Green Hills compiler—they can’t even handle switch prediction
properly. So why are we still trusting these obsolete tools?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
