Kaben123 commented on code in PR #18282:
URL: https://github.com/apache/nuttx/pull/18282#discussion_r2757699201
##########
libs/libc/misc/lib_crc16ccitt.c:
##########
@@ -99,10 +61,45 @@ uint16_t crc16ccittpart(FAR const uint8_t *src, size_t len,
{
size_t i;
uint16_t v = crc16val;
+ static const uint16_t g_crc16_tab[256] =
Review Comment:
> 2\. If there were no mandatory ASIL-D requirements, I think we could relax
such restrictions.
MISRA C:2012 Rule 8.9 is not a mandatory requirement for ASIL D, but as an
Advisory rule, compliance is strongly recommended for ASIL D projects.
Deviations must be made for good technical reasons and documented.
<img width="1767" height="1123" alt="image"
src="https://github.com/user-attachments/assets/006e0d70-ff48-4a18-b104-89fadd39bef9";
/>
> Or should all `Private Data` be cleaned up?
I think "MISRA C:2012 Rule 8.9" should be taken as an acceptable rule for
Nuttx Coding Style.
There is no need to clean up all `Private Data`, only the parts that are
required to conform to the ASILD specification need to be modified.
cc, @wangzhi16 @xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
