Kaben123 commented on code in PR #18282:
URL: https://github.com/apache/nuttx/pull/18282#discussion_r2758847862
##########
libs/libc/misc/lib_crc16ccitt.c:
##########
@@ -99,10 +61,45 @@ uint16_t crc16ccittpart(FAR const uint8_t *src, size_t len,
{
size_t i;
uint16_t v = crc16val;
+ static const uint16_t g_crc16_tab[256] =
Review Comment:
> The table you presented does not mention MISRA C:2012 Rule 8.9
MISRA C is not mandated by ISO 26262 itself, but the use of coding
specifications in ASIL projects is highly recommended.
According to ISO 26262-6:2018 Table 1 (Software unit design and
implementation method), "Avoid global variables or else justify their usage"
(avoid using global variables, Otherwise, its use should be demonstrated) has a
recommendation rating of "++" (highly recommended) in ASIL D and can be
approved by the corresponding MISRA rules including Rule 8.7 and Rule 8.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
