fxysunshine commented on code in PR #18282:
URL: https://github.com/apache/nuttx/pull/18282#discussion_r2758723699
##########
libs/libc/misc/lib_crc16ccitt.c:
##########
@@ -99,10 +61,45 @@ uint16_t crc16ccittpart(FAR const uint8_t *src, size_t len,
{
size_t i;
uint16_t v = crc16val;
+ static const uint16_t g_crc16_tab[256] =
Review Comment:
> If we are to introduce this rule, we need to assess whether Nuttx
developers should still follow this coding style:
https://github.com/apache/nuttx/blob/master/Documentation/contributing/coding_style.rst?plain=1#L2511-L2517
>
> Or should all `Private Data` be cleaned up?
No all `Private Data` be cleaned up, only the private data that only appears
in a single function should move the scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
