xiaoxiang781216 commented on code in PR #18428:
URL: https://github.com/apache/nuttx/pull/18428#discussion_r2845301714
##########
drivers/usbdev/rndis.c:
##########
@@ -2752,6 +2752,25 @@ static void usbclass_resetconfig(FAR struct rndis_dev_s
*priv)
}
}
+/****************************************************************************
+ * Name: rndis_ifup_work
+ *
+ * Description:
+ * Schedule to work queue because netdev_carrier_on API can't be used in
Review Comment:
how about move the interrupt context check and queue wwork inisde
netdev_carrier_on/netdev_carrier_off
##########
drivers/usbdev/rndis.c:
##########
@@ -2860,10 +2879,14 @@ static int usbclass_setconfig(FAR struct rndis_dev_s
*priv, uint8_t config)
/* We are successfully configured */
priv->config = config;
- if (priv->netdev.d_ifup(&priv->netdev) == OK)
- {
- priv->netdev.d_flags |= IFF_UP;
- }
+
+ /* Schedule to work queue because netdev_carrier_on API can't be used in
Review Comment:
but where rndis call netdev_carrier_on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
