anchao commented on code in PR #18428:
URL: https://github.com/apache/nuttx/pull/18428#discussion_r2845815955


##########
drivers/usbdev/rndis.c:
##########
@@ -2752,6 +2752,22 @@ static void usbclass_resetconfig(FAR struct rndis_dev_s 
*priv)
     }
 }
 
+/****************************************************************************
+ * Name: rndis_carrier_on_work
+ *
+ * Description:
+ *   Schedule to work queue because netdev_carrier_on API can't be used in
+ *   interrupt context
+ *
+ ****************************************************************************/
+
+static void rndis_carrier_on_work(FAR void *arg)
+{
+  FAR struct rndis_dev_s *priv = (FAR struct rndis_dev_s *)arg;

Review Comment:
   ```suggestion
     FAR struct rndis_dev_s *priv = arg;
   ```
   I don't understand this PR. Is it because netlink can't be used in interrupt 
context?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to