zhhyu7 commented on code in PR #18428:
URL: https://github.com/apache/nuttx/pull/18428#discussion_r2846601574
##########
drivers/usbdev/rndis.c:
##########
@@ -2752,6 +2752,22 @@ static void usbclass_resetconfig(FAR struct rndis_dev_s
*priv)
}
}
+/****************************************************************************
+ * Name: rndis_carrier_on_work
+ *
+ * Description:
+ * Schedule to work queue because netdev_carrier_on API can't be used in
+ * interrupt context
+ *
+ ****************************************************************************/
+
+static void rndis_carrier_on_work(FAR void *arg)
+{
+ FAR struct rndis_dev_s *priv = (FAR struct rndis_dev_s *)arg;
Review Comment:
> how about change netlink_device_notify() ISR safe?
>
@anchao Okay, if we make this change, I won't need to submit this PR. Will
you directly submit this modification?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
