anchao commented on code in PR #18428:
URL: https://github.com/apache/nuttx/pull/18428#discussion_r2847474980
##########
drivers/usbdev/rndis.c:
##########
@@ -2752,6 +2752,22 @@ static void usbclass_resetconfig(FAR struct rndis_dev_s
*priv)
}
}
+/****************************************************************************
+ * Name: rndis_carrier_on_work
+ *
+ * Description:
+ * Schedule to work queue because netdev_carrier_on API can't be used in
+ * interrupt context
+ *
+ ****************************************************************************/
+
+static void rndis_carrier_on_work(FAR void *arg)
+{
+ FAR struct rndis_dev_s *priv = (FAR struct rndis_dev_s *)arg;
Review Comment:
@raiden00pl
My intention is to fix this issue at the most critical point. Because in
RNDIS, we have modified netdev_carrier_on() to be invoked from a workqueue. If
other network drivers also need to call netdev_carrier_on() in interrupt
context, developers would have to make similar changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
