lupyuen commented on PR #19075: URL: https://github.com/apache/nuttx/pull/19075#issuecomment-4670414672
Yep I agree that embedding PR Metadata (e.g. `depends-on`) inside the PR Body can get problematic: - When we update the PR Metadata: The PR doesn't auto-rebuild. PR Reviewers might be misled by the metadata. - When the PR Metadata is Invalid: We don't see any warnings. This makes it harder to track down CI problems. If we ever need to support PR Metadata in future, we would need a lot more work: 1. Parsing the PR Body should be done safely in a separate GitHub Actions Workflow, in GitHub Script (JavaScript). PR Metadata should be carefully validated and stored as PR Labels or PR Artifacts. Similar to our PR Labeling: https://lupyuen.org/articles/prtarget 2. If there are errors in parsing the PR Body: The GitHub Actions Workflow should trigger a PR Comment, to indicate why the parsing failed 3. If there are changes to the PR Metadata: It should also trigger a PR Comment, to indicate the changes 4. But with these changes, NuttX CI might become too complex to maintain :-( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
