jlaitine commented on code in PR #19116:
URL: https://github.com/apache/nuttx/pull/19116#discussion_r3409195662
##########
libs/libc/pthread/pthread_kill.c:
##########
@@ -61,7 +67,25 @@
int pthread_kill(pthread_t thread, int signo)
{
- int ret = tkill((pid_t)thread, signo);
+ int ret;
+
+#ifdef CONFIG_DISABLE_ALL_SIGNALS
+ struct sched_param param;
Review Comment:
Why not keep the nxsig_dispatch only dispatch signals and not call it at all
if there is no signals to dispatch (signo being 0). We could keep the signo==0
check entirely outside the kernel, since it has nothing to do with actually
dispatching signals, it is only thread alive check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
