patacongo commented on a change in pull request #1728:
URL: https://github.com/apache/incubator-nuttx/pull/1728#discussion_r484435022



##########
File path: boards/Kconfig
##########
@@ -1364,13 +1364,21 @@ config ARCH_BOARD_SABRE_6QUAD
                board featuring the iMX 6Quad CPU.
 
 config ARCH_BOARD_SAMA5D2_XULT
-       bool "Atmel SAMA5D2 Xplained Ultra development board"
+bool "Atmel SAMA5D2 Xplained Ultra development board"
+depends on ARCH_CHIP_ATSAMA5D27
+        select ARCH_HAVE_LEDS
+        select ARCH_HAVE_BUTTONS
+        select ARCH_HAVE_IRQBUTTONS
+---help---
+The port of NuttX to the Atmel SAMA5D2-XULT development board
+

Review comment:
       The above does not follow the indentation rules that we use in Kconfig 
files.  Need a TAB before bool and depends and ---help--- and two TABs before 
"The port of NuttX"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to