ppisa commented on code in PR #3624: URL: https://github.com/apache/nuttx-apps/pull/3624#discussion_r3660559903
########## graphics/microwindows/Make.defs: ########## @@ -0,0 +1,50 @@ +############################################################################ +# apps/graphics/microwindows/Make.defs +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +ifneq ($(CONFIG_GRAPHICS_MICROWINDOWS),) +CONFIGURED_APPS += $(APPDIR)/graphics/microwindows + +# It allows `microwindows/src/include` import. + +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include +CXXFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/drivers Review Comment: ``` CFLAGS += -DMWCONFIG_FILE='"mwconfig.nuttx"' ``` is required for Microwidows use outside this directory for sure. `src/drivers` would be probably require only for custom keyboard or mouse drivers, `graphics/microwindows/microwindows/src/include` is required externally. Mouse and keyboard options and related paths can be moved to `Makefile`, they are required only inside of Microwidows drivers build. For teh custom case, they can be prepared locally from `CONFIG_MICROWINDOWS_KBD_` etc. So this can be limited to local directory only, i.e to `Makefile`for now. ``` HAVE_FNT_SUPPORT = Y ``` is provided by as `#define HAVE_FNT_SUPPORT 1` by `src/include/mwconfig.nuttx`. So I think that it can be removed from `Make.defs` and it should not be needed even in `Makefile`. But needs to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
