ghaerr commented on PR #3624: URL: https://github.com/apache/nuttx-apps/pull/3624#issuecomment-5096417964
> Generally, I see as the best solution do not need for these to be defined by build system to zero. On the Microwindows side, for various reasons the idiom of `#if RTEMS` etc is used a lot more than `#ifdef RTEMS`, mostly so that the same mechanism can be used to turn options on or off without changing an \#ifdef to an \#if. However, it was not the intent to force developers to find all cases of \#if SYM and pass -DSYM=0 everywhere. Thus, I do not agree the best solution is to set otherwise undefined symbols to 0. It seems this may be a problem because of the use of -Wundef in NuttX? > There is one exception > #if __ECOS > This meas that if this header file is included without preceding mwconfig.h include, then there could be a problem. The ECOS port is quite old, and probably doesn't follow some of the more recent ideas of keeping platform build-specific options in a separate configuration file. This could be fixed, but I hesitate to change code that I or others can't easily test in the main repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
