daniel-p-carvalho commented on code in PR #20148: URL: https://github.com/apache/nuttx/pull/20148#discussion_r4031142584
########## net/pkt/pkt.h: ########## @@ -105,6 +105,10 @@ struct pkt_conn_s struct iob_queue_s readahead; /* Read-ahead buffering */ FAR struct iob_s *pendiob; /* The iob currently being sent */ + uint16_t pendiob_len; /* Length of pendiob, to disambiguate Review Comment: You're right - thanks for catching this. I'd updated the comment to say pendiob is always released by devif_poll_pkt_connections() by the time we get here, but left the redundant `conn->pendiob = NULL;` line in place instead of removing it as your patch did. Removed now, matching your suggestion exactly. Also fixed a pre-existing nxstyle alignment issue in the same devif_poll.c block while I was in there (unrelated nerr() call), since CI flags the whole file once it's touched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
