daniel-p-carvalho commented on code in PR #20148: URL: https://github.com/apache/nuttx/pull/20148#discussion_r4029548062
########## include/nuttx/net/ioctl.h: ########## @@ -161,6 +161,10 @@ #define SIOCGIFVLAN _SIOC(0x0043) /* Get VLAN interface */ #define SIOCSIFVLAN _SIOC(0x0044) /* Set VLAN interface */ +/* PTP Timestamping *********************************************************/ + +#define SIOCG_TX_HW_TIMESTAMP _SIOC(0x0046) /* Get hardware TX timestamp */ Review Comment: Sounds good, I'll migrate SIOCS_PTP_ADJFREQ/SIOCS_PTP_ADJPHASE to /dev/ptp0 (registering a lower-half driver against drivers/timers/ptp_clock.c) in this PR. For TX timestamp delivery, I'd rather hold off on migrating SIOCG_TX_HW_TIMESTAMP to SO_TIMESTAMPING until [apache/nuttx#20161](https://github.com/apache/nuttx/pull/20161) merges. Should I keep this PR open as-is for that follow-up once [apache/nuttx#20161](https://github.com/apache/nuttx/pull/20161) merges, mark it as draft in the meantime, or close it and submit a fresh PR later instead? Happy to do whichever fits your workflow better. @wenquan2015 nice work, looking forward to building on top of it once it's in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
