xiaoxiang781216 commented on code in PR #20148: URL: https://github.com/apache/nuttx/pull/20148#discussion_r4032134564
########## include/nuttx/net/ioctl.h: ########## @@ -161,6 +161,10 @@ #define SIOCGIFVLAN _SIOC(0x0043) /* Get VLAN interface */ #define SIOCSIFVLAN _SIOC(0x0044) /* Set VLAN interface */ +/* PTP Timestamping *********************************************************/ + +#define SIOCG_TX_HW_TIMESTAMP _SIOC(0x0046) /* Get hardware TX timestamp */ Review Comment: it's better to split your pr into there new pr: 1. the general network improvement or bugfix 2. implement stm32 eth ptp driver 3. implement stm32 eth hardware timestamp it's fine to reuse this pr for item 2 or 3 if you want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
