xiaoxiang781216 commented on code in PR #20417: URL: https://github.com/apache/nuttx/pull/20417#discussion_r4154503079
########## include/nuttx/sched.h: ########## @@ -33,6 +33,7 @@ #include <stdbool.h> #include <stdint.h> #include <sched.h> +#include <sys/prctl.h> Review Comment: CAP isn't couple with kernel mode, let's drop the 10 patches from this pr ########## include/nuttx/sched.h: ########## @@ -924,6 +928,12 @@ static inline_function bool nxsched_has_gid(FAR struct tcb_s *tcb, FAR struct tcb_s *nxsched_self(void); +#ifdef CONFIG_BUILD_KERNEL Review Comment: why check CONFIG_BUILD_KERNEL? capability should be used in all modes. ########## include/nuttx/fs/fs.h: ########## @@ -147,6 +147,11 @@ #define INODE_IS_NAMEDEVENT(i) INODE_IS_TYPE(i,FSNODEFLAG_TYPE_NAMEDEVENT) #define INODE_IS_HARDLINK(i) INODE_IS_TYPE(i,FSNODEFLAG_TYPE_HARDLINK) +#define FSNODEFLAG_RAWIO 0x00000010 /* Raw storage access */ Review Comment: why do we need flag some driver with RAWIO flags? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
