xiaoxiang781216 commented on code in PR #20417: URL: https://github.com/apache/nuttx/pull/20417#discussion_r4162412817
########## fs/mount/fs_umount2.c: ########## @@ -62,6 +63,11 @@ int nx_umount2(FAR const char *target, unsigned int flags) struct inode_search_s desc; int ret; + if (!nxsched_capable(PR_CAP_RAWIO)) Review Comment: why not merge all PR_CAP_RAWIO in one patch ########## drivers/bch/bchdev_driver.c: ########## @@ -122,6 +123,11 @@ static int bch_open(FAR struct file *filep) FAR struct bchlib_s *bch; int ret = OK; + if (!nxsched_capable(PR_CAP_RAWIO)) Review Comment: remove, already check by: https://github.com/apache/nuttx/pull/20417/changes/4c795c8072d905be031cecf652ef37bd0ba7d2fb#diff-45fe6e5a6529a5265d9338cbbfd4318580490a087320d8ab3645542c07dec51fR152 ########## fs/mount/fs_mount.c: ########## @@ -304,6 +305,11 @@ int nx_mount(FAR const char *source, FAR const char *target, FAR void *fshandle = NULL; int ret; + if (!nxsched_capable(PR_CAP_RAWIO)) Review Comment: ditto ########## binfmt/binfmt_exec.c: ########## @@ -86,6 +87,11 @@ static int exec_internal(FAR const char *filename, int pid; int ret; + if (!nxsched_capable(PR_CAP_SPAWN)) Review Comment: should we move the check into sched/posix_spawn? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
