royzah commented on code in PR #20417:
URL: https://github.com/apache/nuttx/pull/20417#discussion_r4164661217


##########
drivers/bch/bchdev_driver.c:
##########
@@ -122,6 +123,11 @@ static int bch_open(FAR struct file *filep)
   FAR struct bchlib_s *bch;
   int ret = OK;
 
+  if (!nxsched_capable(PR_CAP_RAWIO))

Review Comment:
   not only tho. block_proxy makes /dev/tmpcXXXXXX (just a counter, easy to 
guess) and unlinks it only after the open, so another task can grab it in that 
gap. and apps can call bchdev_register directly too, eg examples/mtdrwb makes 
/dev/mtd0 and it stays. bch_open is the one spot both go thru. ok to keep it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to