xiaoxiang781216 commented on code in PR #20367: URL: https://github.com/apache/nuttx/pull/20367#discussion_r4158155991
########## boards/arm/common/stm32/src/Make.defs: ########## @@ -215,6 +215,14 @@ endif ifeq ($(CONFIG_STM32_ROMFS),y) CSRCS += stm32_romfs_initialize.c +stm32_romfs_initialize.o: ../../../$(patsubst "%",%,$(CONFIG_STM32_ROMFS_IMAGEFILE)) +../../../../../apps/examples/elf/main/elf_romfs.img: + $(MAKE) -C ../../../../../apps/platform all APPDIR=.. TOPDIR=$(TOPDIR) Review Comment: does jimtcl config by autoconf? if yes, it's more simple to: 1. run autoconf in the host and use the generated config.h as the template 2. add #fidef CONFIG_xxx around HAVE_xxx in config.h if not, could we skip the link but just check compiler result? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
