btashton commented on pull request #1788:
URL: https://github.com/apache/incubator-nuttx/pull/1788#issuecomment-692349281
> The change proposed for GPIO feels a bit too ad-hoc and would deviate how
this works from every other architecture. Normally a pin is either configured
or unconfigured. A "disabled" flag of the pincfg does not really map to that,
it would require runtime check of that value everywhere.
but how would that work you have
```
.miso_pin = BOARD_SPI0_MISO_PIN,
```
which expects to be a GPIO pin definition. You need to supply something to
that otherwise you are breaking the abstraction and checking if
`BOARD_SPI0_MISO_PIN` is defined in code that should just be using `.miso_pin`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
