LingaoM commented on code in PR #20686: URL: https://github.com/apache/nuttx/pull/20686#discussion_r4388152502
########## libs/zblue/CMakeLists.txt: ########## @@ -0,0 +1,40 @@ +# ############################################################################## +# libs/zblue/CMakeLists.txt Review Comment: I won’t comment on where the Bluetooth code should be placed, but I notice this PR consists entirely of code—where are the tests? Since we already have the [BSWorld](https://github.com/XiaoMi/bsworld) simulation testing system, and it’s now supported in the default CI pipeline, we really should add corresponding Bluetooth tests for this PR. Otherwise, how can we ensure the stability of such an extensive set of fixes? Although BR/EDR is not yet supported, the vast majority of LE (Low Energy) functionality can certainly be tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
