acassis commented on code in PR #20686: URL: https://github.com/apache/nuttx/pull/20686#discussion_r4389982657
########## libs/zblue/CMakeLists.txt: ########## @@ -0,0 +1,40 @@ +# ############################################################################## +# libs/zblue/CMakeLists.txt Review Comment: @anchao yes, Zephyr is known to get using everything on kernel side, even their SSH port run on the kernel side. You are right about the performance tradeoff but we need to evaluate if this tradeoff is worse than the security hole it adds. I never used NimBLE in Protected/Kernel mode, maybe @raiden00pl had some experience with it and could share his view about the performance. ########## libs/zblue/CMakeLists.txt: ########## @@ -0,0 +1,40 @@ +# ############################################################################## +# libs/zblue/CMakeLists.txt Review Comment: @anchao yes, Zephyr is known to get using everything on kernel side, even their SSH port runs on the kernel side. You are right about the performance tradeoff but we need to evaluate if this tradeoff is worse than the security hole it adds. I never used NimBLE in Protected/Kernel mode, maybe @raiden00pl had some experience with it and could share his view about the performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
