casaroli commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6463928689
> does changing commit message "MPU and FPU sources stay in the build" & remove kconfig of FPU & MPU selection works? Removing `select ARCH_HAVE_MPU` fixes the build, because `ARCH_USE_MPU` depends on it (arch/Kconfig:826). But then `tricore_mpu.c`, `tricore_mpu.h` and the `ARCH_MPU_*` options stay in this PR with no configuration that builds them. The same is true for `tricore_fpu.c` without `ARCH_HAVE_FPU`. Fix: move `tricore_mpu.c`, `tricore_mpu.h`, the `ARCH_MPU_*` options and `select ARCH_HAVE_MPU` to #21042. For the FPU, either select `ARCH_HAVE_FPU` for `ARCH_CHIP_FAMILY_TC4X` or move `tricore_fpu.c` out too. Then correct the message of aac7762a90. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
