ssekar15 commented on code in PR #19041:
URL: https://github.com/apache/nuttx/pull/19041#discussion_r4408614606


##########
arch/tricore/src/common/tricore_stackframe.c:
##########
@@ -29,7 +29,7 @@
 #include <sys/types.h>
 #include <stdint.h>
 #include <sched.h>
-#include <nuttx/debug.h>
+#include <debug.h>

Review Comment:
   every changes are compiled, tested on board. FYI
   
   ```
   nuttx (tricore-upstream-split-7-of-10) $ make distclean
   nuttx (tricore-upstream-split-7-of-10) $ ./tools/configure.sh -E 
a2g-tc375-lite:nsh
   
   #
   # configuration written to .config
   #
   nuttx (tricore-upstream-split-7-of-10) $ EXTRAFLAGS="-g3" make -j32
   Create version.h
   LN: platform/board to /home/saravanan/repo/apps/platform/dummy
   Register: nsh
   Register: sh
   Register: dd
   CPP:  nuttx/boards/tricore/tc3x/a2g-tc375-lite/scripts/tricore-llvm.ld-> 
nuttx/boards/tricore/tc3x/a2g-tc375-lite/scripts/tricore-lLD: nuttx
   CP: nuttx.hex
   ```
   
   To make sure the mentioned file is considered for compilation, added `#errr` 
 in file
   ```
   nuttx (tricore-upstream-split-7-of-10) $ vim 
arch/tricore/src/common/tricore_stackframe.c
   nuttx (tricore-upstream-split-7-of-10) $ EXTRAFLAGS="-g3" make -j32
   ./common/tricore_stackframe.c:33:2: error: invalid preprocessing directive
      33 | #errr
         |  ^
   1 error generated.
   ```
   
   Please share if I missed anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to