xiaoxiang781216 commented on code in PR #19041: URL: https://github.com/apache/nuttx/pull/19041#discussion_r4404638264
########## arch/tricore/src/illd/tc3xx/Configurations/Ifx_Cfg_Ssw.h: ########## @@ -1,111 +0,0 @@ -/**************************************************************************** - * arch/tricore/src/illd/tc3xx/Configurations/Ifx_Cfg_Ssw.h Review Comment: how do you make the code pass build by just removing the code? please ensure your patch can be built one by one. ########## arch/tricore/src/common/tricore_mpu.c: ########## @@ -1,1438 +0,0 @@ -/**************************************************************************** - * arch/tricore/src/common/tricore_mpu.c - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. The - * ASF licenses this file to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance with the - * License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT - * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the - * License for the specific language governing permissions and limitations - * under the License. - * - ****************************************************************************/ - -/**************************************************************************** - * Included Files - ****************************************************************************/ - -#include <stdio.h> -#include <nuttx/debug.h> - -#include <arch/barriers.h> - -#include "tricore_mpu.h" -#include "tricore_internal.h" - -/**************************************************************************** - * Private Variables - ****************************************************************************/ - -static unsigned int g_mpu_data_region; -static unsigned int g_mpu_code_region; -static unsigned int g_mpu_set; - -/**************************************************************************** - * Private Functions - ****************************************************************************/ - -static uint32_t get_dpre_value(unsigned int set) Review Comment: please replace iLLD function call with the native implementation, but not remove the entire file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
