xiaoxiang781216 commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6498110923
> > > > Because your change is far away from merging even start review. You can ask the original author @anchao to do the justification. > > > > > > > > > So the duplicated efforts are intentional? > > > See [#19041 (comment)](https://github.com/apache/nuttx/pull/19041#issuecomment-5079385584), I have mentioned that we got TASKING access and resuming the effotts. > > > > > > but dropping iLLD isn't related to TASKING at all. > > iLLD removal is covered in this PR already. Split into multiple PR's was agreed and part of the effort. > > > > But then the duplicated efforts & PR's started from August 10th i.e #19766 #19783 #19829 #19836 and so on. > > > > > > Since this PR stall for a long time > > Ping in this would be suffice. Isn't that the usual way open source / NuttX works? > > > quality isn't good enough. > > Could you please be more precious or review the parts which would like to see as a change in this PR? > > > And we want to bring up tricore ci to the community, removing iLLD is the first step for it. > > Which we already initiated as part of our scope in this PR. And you duplicated it intentionally. > > > BTW, the work to remove iLLD isn't huge(around 2000 line of code), either yours or ours is fine. But the change need apply to the current code base step by step like #19766 #19783 #19829 #19836, but not this PR. > > None justifies duplicated effort. No Ping, No tagging on other PR's, No reference to this PR. > > Now, we are happy to align and split the changes into multiple PR's and in-fact this PR can be closed covering all the changes independently. But I strongly feel disrespectful and dislike the idea of duplication of our completed efforts. OK, let's stop the complaint, and focus on the PR. If you can split your change into the reasonable pr, like https://github.com/apache/nuttx/pull/21039, it will be reviewed and merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
