parthitce commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6496977979
> > > @xiaoxiang781216 I think who submit the PR first should have priority, but in fact a bigger PR is more difficult to be reviewed and merged. @parthitce I think as a rule of thumb: instead of submitting all the changes in a single PR it is all better to divide in smaller PRs to make it easier to review and get merged. > > > > > > Understood and clear. Split is happening now in our end. Will have more split of PR's per scope and testing is on-going across three suppored compilers. > > But regarding the duplicated effort, see the list below (@zyfeier @jerpelea) > > > > * [arch/tricore: fpu: drop iLLD dependency and fix Makefile #20018](https://github.com/apache/nuttx/pull/20018) > > * [arch/tricore: mpu iLLD drop and per-set flags refactor #20016](https://github.com/apache/nuttx/pull/20016) > > * [arch/tricore: drop illd dependence for atomic #19953](https://github.com/apache/nuttx/pull/19953) > > * [arch/tricore: drop iLLD dependency in hwdebug #19836](https://github.com/apache/nuttx/pull/19836) > > * [{bp-19783} arch/tricore: drop iLLD dependency in cache and perf paths #19829](https://github.com/apache/nuttx/pull/19829) > > * [arch/tricore: drop iLLD dependency in cache and perf paths #19783](https://github.com/apache/nuttx/pull/19783) > > * [arch/tricore: idle donot depend on illd #19766](https://github.com/apache/nuttx/pull/19766) > > * [arch/tricore: rework trap handling without iLLD #21110](https://github.com/apache/nuttx/pull/21110) > > > > Looking at the timeline, this PR is dated June and all the duplication started in August. And @xiaoxiang781216 is aware of this PR and why duplicate when we are actively responding & working with community? > > And why dismiss review #21088 and merge? > > Because your change is far away from merging even start review. You can ask the original author @anchao to do the justification. So the duplicated efforts are intentional? See https://github.com/apache/nuttx/pull/19041#issuecomment-5079385584, I have mentioned that we got TASKING access and resuming the effotts. But then the duplicated efforts & PR's started from August 10th i.e https://github.com/apache/nuttx/pull/19766 https://github.com/apache/nuttx/pull/19783 https://github.com/apache/nuttx/pull/19829 https://github.com/apache/nuttx/pull/19836 and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
