cederom commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-6498985853
Thank you @parthitce ! Very nice that you provide native implementation!! Lets take a look at CI formatting complains in the first place (https://github.com/apache/nuttx/actions/runs/40737186472/job/123293724499?pr=19041#step:3:133): ``` ../nuttx/tools/checkpatch.sh -c -u -m -g 8caba095575dfa0c47fd6ca4b974dd5e69798535..HEAD Used config files: 1: .codespellrc ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/tricore/src/cmake/tasking.cmake cmake-format check failed, run following command to update the style: $ cmake-format <src> -o <dst> ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/tricore/src/cmake/tasking.cmake arch/tricore/src/Makefile: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/Makefile: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/common/Make.defs: error: Makefile modified but arch/tricore/src/common/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc3x/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc3xx/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc4x/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc4xx/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc397/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc3xx/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc4da/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. arch/tricore/src/tc4xx/Make.defs: error: Makefile modified but arch/tricore/src/CMakeLists.txt was not updated. Please maintain build-system parity between Make and CMake. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. boards/tricore/tc397/a2g-tc397-5v-tft/scripts/Make.defs: error: Makefile created/modified but no corresponding CMakeLists.txt exists. Please add CMake build support for build-system parity. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. boards/tricore/tc4da/triboard_tc4x9_com/scripts/Make.defs: error: Makefile created/modified but no corresponding CMakeLists.txt exists. Please add CMake build support for build-system parity. If this is a Make-only change, include '[skip-cmake-parity]' in the commit message. Some checks failed. For contributing guidelines, see: https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md Error: Process completed with exit code 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
