parthitce commented on code in PR #21131:
URL: https://github.com/apache/nuttx/pull/21131#discussion_r4415261351


##########
libs/libc/machine/tricore/Make.defs:
##########
@@ -32,12 +32,6 @@ endif
 
 AFLAGS += 
${INCDIR_PREFIX}$(TOPDIR)$(DELIM)libs$(DELIM)libc$(DELIM)machine$(DELIM)tricore
 
-# The optimized assembly routines use TC1.8 instructions (e.g. ld.dd/st.dd
-# quad-word access).  Force the assembler to target TC1.8 so the build does
-# not depend on the board's ambient platform flags.
-
-AFLAGS += -Wa,-mtc18

Review Comment:
   Now that you have removed the flag, how does instructions like ld.dd, st.dd 
compiled in TC3x?



##########
libs/libc/machine/tricore/gnu/arch_memcpy.S:
##########


Review Comment:
   All these files under libc machine for tricore is only for TC1.8 i.e TC4x 
SoC's? What about TC1.6 and TC3x SoC's?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to