parthitce commented on PR #21131: URL: https://github.com/apache/nuttx/pull/21131#issuecomment-6503044571
> ## Summary > > Fix two build breaks for TC3xx (TC397) on current master. > > 1. **arch/tricore/tc3xx: follow the iLLD TC39xB pin map rename** > iLLD v1.22.0 renamed `_PinMap/TC39x` to `TC39xB`, so both the CMake and Make builds of tc3xx can no longer find the pin map headers. Update the paths in `tc3xx/CMakeLists.txt` and `tc3xx/Make.defs` accordingly. > > 2. **libc/tricore: drop the forced -mtc18 assembler flag** > `libs/libc/machine/tricore/Make.defs` unconditionally added `AFLAGS += -Wa,-mtc18`, which assembles the libc sources for TC1.8 even on TC3xx (TC1.6.2) and makes the final link fail with an architecture mismatch. TC4xx already passes `-mtc18` via `ARCHCPUFLAGS` in `arch/tricore/src/tc4xx/Toolchain.defs`, so the forced flag is redundant and is removed. > > > ## Impact > > * TC3xx: CMake and Make builds work again. How? It's impossible to compile these changes in my end. > > * TC4xx: no change expected, `-mtc18` is still provided by `tc4xx/Toolchain.defs`. > > > ## Testing > > a2g-tc397-5v-tft, GCC, clean build on master `70b99f05bd3`: > > * CMake: pass > > * Make: pass Could you please share the build logs? Am curious how your GCC ignored the asm errors for ld.dd, st.dd and so on. Also did you test the changes with TASKING? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
