zhangyu-duck commented on code in PR #21504:
URL: https://github.com/apache/nuttx/pull/21504#discussion_r4510109396


##########
arch/tricore/src/common/tricore_irq.c:
##########
@@ -36,9 +36,14 @@
 
 #include "tricore_internal.h"
 
-#include "IfxSrc.h"
-#include "IfxCpu.h"
-#include "IfxInt_reg.h"
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* Service request control register of an IRQ */
+
+#define TRICORE_SRC(irq) \

Review Comment:
   remove ,repeat in irq.h



##########
boards/tricore/tc3xx/a2g-tc397-5v-tft/scripts/Lcf_Tasking_Tricore_Tc.lsl.kernel:
##########
@@ -347,7 +347,19 @@ derivative tc39
         {
             group int_tab_tc (ordered)
             {
-                group (run_addr=(INTTAB)+0x1FE0) select 
".text.inttab0.intvec.0ff";
+#if CONFIG_CPU_COREID == 0
+                group (run_addr=(INTTAB)+0x1FE0) select ".text.intvec_cpu0";
+#elif CONFIG_CPU_COREID == 1
+                group (run_addr=(INTTAB)+0x1FE0) select ".text.intvec_cpu1";
+#elif CONFIG_CPU_COREID == 2

Review Comment:
   we can just define intvec



##########
boards/tricore/tc4xx/triboard_tc4x9_com/scripts/Lcf_Tasking_Tricore_Tc.lsl.kernel:
##########
@@ -362,7 +362,19 @@ derivative tc4D
         {
             group int_tab_tc (ordered)
             {
-                group (run_addr=(INTTAB)+0x1FE0) select 
".text.inttab0.intvec.0ff";
+#if CONFIG_CPU_COREID == 0
+                group (run_addr=(INTTAB)+0x1FE0) select ".text.intvec_cpu0";
+#elif CONFIG_CPU_COREID == 1
+                group (run_addr=(INTTAB)+0x1FE0) select ".text.intvec_cpu1";
+#elif CONFIG_CPU_COREID == 2
+                group (run_addr=(INTTAB)+0x1FE0) select ".text.intvec_cpu2";
+#elif CONFIG_CPU_COREID == 3

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to